[Merged by Bors] - Add product image selection struct #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sbernauer changed the title 8 tasks
7 tasks
nightkr reviewed Oct 31, 2022
nightkr reviewed Oct 31, 2022
…etech/operator-rs into feature/product-image-selection
| bors cancel |
| Canceled. |
| I will also add some helpers for the recommended labels |
| @teozkr added the label helpers, please have a look |
nightkr reviewed Nov 11, 2022
Co-authored-by: teozkr <teo@nullable.se>
Co-authored-by: teozkr <teo@nullable.se>
Co-authored-by: teozkr <teo@nullable.se>
Co-authored-by: teozkr <teo@nullable.se>
Co-authored-by: teozkr <teo@nullable.se>
Co-authored-by: teozkr <teo@nullable.se>
nightkr approved these changes Nov 11, 2022
| bors r+ |
bors bot pushed a commit that referenced this pull request Nov 11, 2022
## Description For #470 Reference implementation in kafka: stackabletech/kafka-operator#482 ADR is [here](https://docs.stackable.tech/home/stable/contributor/adr/ADR018-product_image_versioning.html) The idea is to add all the currently known enum variants to see that the concept works. Before merging the `ProductImageSelection::Stackable` enum variant will be removed/commented out.
| Pull request successfully merged into main. Build succeeded:
|
bors bot changed the title This was referenced Dec 5, 2022
bors bot pushed a commit to stackabletech/kafka-operator that referenced this pull request Dec 13, 2022
# Description For stackabletech/operator-rs#470 Reference implementation of stackabletech/operator-rs#476 Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Malte Sander <contact@maltesander.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
For #470
Reference implementation in kafka: stackabletech/kafka-operator#482
ADR is here
The idea is to add all the currently known enum variants to see that the concept works. Before merging the
ProductImageSelection::Stackableenum variant will be removed/commented out.Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information