Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Dec 8, 2021

Description

This is mostly imported from ZooKeeper STFU, but with the default path resolution restored.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
@nightkr nightkr marked this pull request as ready for review December 9, 2021 12:06
@nightkr
Copy link
Contributor Author

nightkr commented Dec 9, 2021

Mostly R4R. The only remaining question mark is whether to wait for a release of stackabletech/product-config#43 so we can work with Path/PathBuf where it fits better (added comments for those cases).

@nightkr nightkr requested a review from a team December 9, 2021 12:07
@nightkr
Copy link
Contributor Author

nightkr commented Dec 9, 2021

Upgraded to product-config 0.3.0 now, so should be ready for review @soenkeliebau

Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nightkr nightkr merged commit 4b1fe4d into main Dec 9, 2021
@nightkr nightkr deleted the feature/structopt branch December 9, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants