fix: Invalid termination_grace_period default in ProbeBuilder #1090
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Noticed in https://testing.stackable.tech/job/superset-operator-it-weekly/69
create Pod superset-node-default-0 in StatefulSet superset-node-default failed error: Pod "superset-node-default-0" is invalid: [spec.containers[0].livenessProbe.terminationGracePeriodSeconds: Invalid value: 0: must be greater than 0, spec.containers[0].readinessProbe.terminationGracePeriodSeconds: Invalid value: 0: must be greater than 0, spec.containers[0].readinessProbe.terminationGracePeriodSeconds: Invalid value: 0: must not be set for readinessProbes, spec.containers[0].startupProbe.terminationGracePeriodSeconds: Invalid value: 0: must be greater than 0]
Also copy some docs from k8s docs
Definition of Done Checklist
Author
Reviewer
Acceptance