Skip to content

fix: Derive Clone for ProbeBuilder and ProbeAction #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2025
Merged

fix: Derive Clone for ProbeBuilder and ProbeAction #1082

merged 4 commits into from
Aug 25, 2025
+16 −3

Conversation

@sbernauer
Copy link
Member

Description

Small improvement of #1078

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
@sbernauer sbernauer mentioned this pull request Aug 21, 2025
Merged
20 tasks
NickLarsenNZ
NickLarsenNZ approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sbernauer sbernauer added this pull request to the merge queue Aug 25, 2025
Merged via the queue into main with commit ce8b52b Aug 25, 2025
8 checks passed
@sbernauer sbernauer deleted the fix/probe-builder-clone branch August 25, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sbernauer @NickLarsenNZ