-
- Notifications
You must be signed in to change notification settings - Fork 16
feat(stackable-versioned)!: Add conversion tracking #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
76 tasks
46acd20
to 3ec678e
Compare This uses correct error handling by letting the error accumulator handle the fallible function. Previously, this panicked, because the accumulator was dropped without being finished.
a72df96
to 7411abd
Compare 7411abd
to 4009271
Compare NickLarsenNZ reviewed Jul 7, 2025
sbernauer reviewed Jul 7, 2025
crates/stackable-versioned-macros/src/codegen/container/struct/conversion.rs Outdated Show resolved Hide resolved
sbernauer reviewed Jul 8, 2025
sbernauer reviewed Jul 8, 2025
sbernauer reviewed Jul 8, 2025
crates/stackable-versioned/tests/snapshots/conversions__pass@persons_to_v3.json.snap Outdated Show resolved Hide resolved
sbernauer previously approved these changes Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % remaining comment and conflicts
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer previously approved these changes Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we have test failures
Ah! This was allowed previously. I will update the test. |
sbernauer previously approved these changes Jul 10, 2025
sbernauer approved these changes Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#642
Caution
It should be noted, that only simple additions of fields can be tracked across conversions. Complex action combinations and other types of changes cannot be tracked. Support for this will be added in the future.
Summary
crd(...)
instead ofk8s(...)
.Default
.experimental_conversion_tracking
flag.nested
flag was added to mark individual fields as nested (indicating that the sub struct also contains changes which need to be tracked).Learnings from this PR