feat(stackable-telemetry)!: Allow configuration of file_log_max_files #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
BREAKING: `FileLogSettingsBuilder::with_max_log_files` which took a `usize` was renamed to `FileLogSettingsBuilder::with_max_files` and now takes an `impl Into<Option<usize>>`
Techassi approved these changes Apr 11, 2025
NickLarsenNZ deleted the feat/stackable-telemetry-file-appender-max-files branch This was referenced Apr 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#639
BREAKING: Allow configuration of
file_log_max_files.--file-log-max-filesCLI argument (env:FILE_LOG_MAX_FILES).FileLogSettingsBuilder::with_max_log_fileswhich took ausizewas renamed toFileLogSettingsBuilder::with_max_filesand now takes animpl Into<Option<usize>>for improved builder ergonomics.