Skip to content

ClusterResources should take the operator and controller names separately #482

@nightkr

Description

@nightkr

Currently, ClusterResources takes a single manager argument that must be unique per controller. The documentation suggests identifying both the controller and operator names (foo-operator_foo-controller), but in practice many single-controller operators just use the operator name (foo-operator).

This is not only inconsistent across the platform, but can lead to orphaned resources during upgrades that add more controllers (necessitating a switch to the expanded format). Additionally, it's generally a convention that un-namedspaced identifiers are reserved for the cluster administrators and users, third-party software should use the ns/id format for string keys (such as field managers or labels).

Acceptance

  • ClusterResources::new takes separate arguments for the operator and controller names
  • labels::get_recommended_labels takes separate arguments for the operator and controller names
  • managed-by labels and field managers follow the operator/controller format
  • The documentation is amended to encourage FQDN-style operator names (for example: zookeeper.stackable.tech rather than zookeeper-operator)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions