Skip to content

Refactor/consolidate auth crd #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 30, 2023
Merged

Refactor/consolidate auth crd #498

merged 21 commits into from
Aug 30, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Aug 25, 2023 •
edited by razvan
Loading

Description

consolidated auth config

fixes #485

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) 
# Reviewer - [x] Code contains useful comments - [x] (Integration-)Test cases added - [x] Documentation added or updated - [x] Changelog updated - [x] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added
@maltesander maltesander added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels Aug 25, 2023
@maltesander maltesander self-assigned this Aug 25, 2023
@maltesander maltesander marked this pull request as ready for review August 25, 2023 15:53
@maltesander maltesander requested a review from a team August 25, 2023 15:53
@maltesander
Copy link
Member Author

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/40/
@razvan razvan requested review from razvan and removed request for a team August 29, 2023 07:27
razvan
razvan previously approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See the comment regarding the docs though.
@maltesander @razvan
Update docs/modules/nifi/pages/usage_guide/security.adoc
716799d 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@maltesander maltesander requested a review from razvan August 29, 2023 13:42
razvan
razvan approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@maltesander
Copy link
Member Author

One more try: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/41/
@maltesander maltesander added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 4d3f8d1 Aug 30, 2023
@maltesander maltesander deleted the refactor/consolidate-auth-crd branch August 30, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

2 participants

@maltesander @razvan