[Merged by Bors] - Adjust NiFi repository sizes depending on configured PVC sizes #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| We could do a fixed safety margin for provenance and flowfiles, but NiFi itself only accepts percentages for the content archive. Is it ok to just use percentage offsets for everything? @lfrancke |
| I'm fine wtih that |
32 tasks
sbernauer reviewed Nov 7, 2022
sbernauer approved these changes Nov 7, 2022
5 tasks
sbernauer approved these changes Nov 8, 2022
bors bot pushed a commit to stackabletech/operator-rs that referenced this pull request Nov 8, 2022
## Description This is used by stackabletech/nifi-operator#371. Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
| bors r+ |
bors bot pushed a commit that referenced this pull request Nov 8, 2022
# Description Fixes #354 Currently this reserves a constant 90% of the PVC size. In practice this headroom "should" probably be scaled based on the complexity on the NiFi graph, but that's not really a thing we can predict easily. This has been running over the weekend with a test cluster and it has cleaned up and stayed working over that period, with all volumes sitting around their respective fill points.
| Pull request successfully merged into main. Build succeeded: |
bors bot changed the title sbernauer reviewed Nov 10, 2022
Comment on lines -234 to -235
| default: | ||
| capacity: null |
There was a problem hiding this comment.
I think this is the accidental breaking change
7 tasks
bors bot pushed a commit that referenced this pull request Nov 10, 2022
# Description This was introduced in #371, when I fragmentified the cluster resources without adding moving the `#[serde(default)]` attributes into `#[fragment_attrs]` blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #354
Currently this reserves a constant 90% of the PVC size. In practice this headroom "should" probably be scaled based on the complexity on the NiFi graph, but that's not really a thing we can predict easily.
This has been running over the weekend with a test cluster and it has cleaned up and stayed working over that period, with all volumes sitting around their respective fill points.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information