Skip to content

refactor: combine the operator lib and binary crates #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

refactor: combine the operator lib and binary crates #638

merged 1 commit into from
Nov 15, 2023

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Nov 15, 2023 •
edited by sbernauer
Loading

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [ ] Changes need to be "offline" compatible 
# Reviewer - [x] Code contains useful comments - [x] (Integration-)Test cases added - [x] Documentation added or updated - [x] Changelog updated - [x] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added
sbernauer
sbernauer previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment
@sbernauer
Copy link
Member

sbernauer commented Nov 15, 2023 •
edited
Loading

Please also add a changelog entry similar to "Consolidate Rust workspace members" to CHANGELOG.md
@NickLarsenNZ NickLarsenNZ force-pushed the chore/combine-operator-and-binary branch from 906e5bd to 4663a95 Compare November 15, 2023 16:44
@NickLarsenNZ NickLarsenNZ force-pushed the chore/combine-operator-and-binary branch from 4663a95 to ce268a9 Compare November 15, 2023 16:45
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 67c6e16 Nov 15, 2023
@NickLarsenNZ NickLarsenNZ deleted the chore/combine-operator-and-binary branch November 15, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@NickLarsenNZ @sbernauer