Skip to content

Let secret op create pkcs12 stores #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 26, 2023
Merged

Let secret op create pkcs12 stores #621

merged 10 commits into from
Sep 26, 2023

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Sep 12, 2023 •
edited
Loading

Description

  • removed copying of keystores, now accessed directly vom secret-op moints (nothing is added)
  • do not import system trust store anymore
  • removed prepare container

fixes #618

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Changes are OpenShift compatible - [x] CRD changes approved - [x] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [x] Changes need to be "offline" compatible 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added
@maltesander maltesander requested a review from a team September 12, 2023 06:43
@maltesander maltesander self-assigned this Sep 12, 2023
@sbernauer
Copy link
Member

I would have excepted much more simplification similar to stackabletech/zookeeper-operator#695,
as in the case of Kafka I think we don't need to add additional certs to trust and keystore, so we should be able to straight up mount and use trust and keystores.
@maltesander
Copy link
Member Author

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/48/
sbernauer
sbernauer reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, really like this!
sbernauer
sbernauer requested changes Sep 26, 2023
View reviewed changes
@maltesander @sbernauer
Update CHANGELOG.md
090e195 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
sbernauer previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@sbernauer sbernauer added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change release/23.11.0 labels Sep 26, 2023
@maltesander maltesander added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit a4ec09f Sep 26, 2023
@maltesander maltesander deleted the let-secret-op-create-pkcs12-stores branch September 26, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/23.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

2 participants

@maltesander @sbernauer