Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 2, 2023

Description

Part of stackabletech/issues#404

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Changes are OpenShift compatible - [x] CRD changes approved - [x] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 
@sbernauer sbernauer self-assigned this Aug 2, 2023
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 754b0b4 Aug 2, 2023
@sbernauer sbernauer deleted the feat/stackable-version branch August 2, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants