Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Jun 6, 2023

Description

Part of: stackabletech/issues#394

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/42/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [x] Feature Tracker has been updated - [x] Proper release label has been added 

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Smoke tests with resource quotas feat: Set explicit resources on all containers Jun 28, 2023
@maltesander maltesander self-assigned this Jun 29, 2023
@maltesander maltesander marked this pull request as ready for review June 29, 2023 12:50
@maltesander maltesander requested a review from a team June 29, 2023 14:08
@sbernauer sbernauer self-assigned this Jun 29, 2023
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor stuff

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander maltesander requested a review from sbernauer June 29, 2023 14:31
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM when tests pass

@maltesander
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 30, 2023
# Description Part of: stackabletech/issues#394 test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/42/ Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Malte Sander <contact@maltesander.com>
@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Set explicit resources on all containers [Merged by Bors] - feat: Set explicit resources on all containers Jun 30, 2023
@bors bors bot closed this Jun 30, 2023
@bors bors bot deleted the feat/resource-quotas branch June 30, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants