Skip to content

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented May 23, 2023

Description

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/39/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team May 23, 2023 08:46
@maltesander maltesander self-assigned this May 23, 2023
@maltesander maltesander mentioned this pull request May 23, 2023
2 tasks
@maltesander maltesander marked this pull request as ready for review May 23, 2023 09:43
@maltesander maltesander linked an issue May 23, 2023 that may be closed by this pull request
2 tasks
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request May 23, 2023
@bors
Copy link
Contributor

bors bot commented May 23, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Support Kafka 3.4.0 [Merged by Bors] - Support Kafka 3.4.0 May 23, 2023
@bors bors bot closed this May 23, 2023
@bors bors bot deleted the feat/kafka-3.4.0 branch May 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants