Skip to content

Conversation

@sbernauer
Copy link
Member

Description

For stackabletech/issues#360

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure i like this.

This basically exposes a (currently) useless struct (in terms of never read) but does not add any functionality (i see the breaking change for listener op point). We had the ClusterIP svc and Nodeports for pods before.
This was never in here, no new functionality added and now people can set a setting that does not have any effect.

I would wait for listener op to be ready and then implement this.
(We could add a hint in the docs though)

@sbernauer
Copy link
Member Author

Agreed, we can simply skip the change 👍

@sbernauer sbernauer closed this Apr 6, 2023
@sbernauer sbernauer deleted the feat/service-type branch May 9, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants