Skip to content

[Merged by Bors] - Fix node selector #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Fix node selector #530

wants to merge 6 commits into from

Conversation

@Maleware
Copy link
Member

Description

According to stackabletech/issues#300, fixes node selector.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@Maleware Maleware mentioned this pull request Dec 20, 2022
Closed
4 tasks
@fhennig fhennig self-requested a review December 21, 2022 08:36
fhennig
fhennig approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Maleware
Copy link
Member Author

bors merge
bors bot pushed a commit that referenced this pull request Dec 21, 2022
@Maleware
Fix node selector (#530)
1bec031 
# Description According to stackabletech/issues#300, fixes node selector.
@fhennig
Copy link
Contributor

fhennig commented Dec 21, 2022

bors cancel
@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Canceled.
fhennig
fhennig suggested changes Dec 21, 2022
View reviewed changes
@fhennig
Copy link
Contributor

fhennig commented Dec 21, 2022

bors merge
bors bot pushed a commit that referenced this pull request Dec 21, 2022
@Maleware @fhennig
Fix node selector (#530)
c833a32 
# Description According to stackabletech/issues#300, fixes node selector. Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Fix node selector [Merged by Bors] - Fix node selector Dec 21, 2022
@bors bors bot closed this Dec 21, 2022
@bors bors bot deleted the Fix_Node_Selector branch December 21, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Maleware @fhennig