Skip to content

[Merged by Bors] - Adapted versions to 3.3.1 #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Adapted versions to 3.3.1 #492

wants to merge 4 commits into from

Conversation

maltesander
Copy link
Member

Description

fixes #486

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@maltesander maltesander requested a review from a team October 11, 2022 11:55
@maltesander maltesander self-assigned this Oct 11, 2022
sbernauer
sbernauer approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if integration test passes
tests/test-definition.yaml
dimensions:
- name: kafka
values:
- 2.7.1-stackable0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me. Might be worth having a general and communicated strategy about this
@maltesander maltesander marked this pull request as ready for review October 11, 2022 12:58
@maltesander
Copy link
Member Author

bors merge
bors bot pushed a commit that referenced this pull request Oct 11, 2022
@maltesander
Adapted versions to 3.3.1 (#492)
c1912ad 
# Description fixes #486 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 11, 2022

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Adapted versions to 3.3.1 [Merged by Bors] - Adapted versions to 3.3.1 Oct 11, 2022
@bors bors bot closed this Oct 11, 2022
@bors bors bot deleted the kafka-3.3.1 branch October 11, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@maltesander @sbernauer