Skip to content

[Merged by Bors] - Getting started guide #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - Getting started guide #452

wants to merge 11 commits into from

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Aug 18, 2022

Description

fixes #447

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@maltesander maltesander requested a review from a team August 18, 2022 10:48
@fhennig fhennig self-assigned this Aug 18, 2022
fhennig
fhennig suggested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll render it locally and test the script now, but this is what I have for now.
fhennig
fhennig reviewed Aug 18, 2022
View reviewed changes
@maltesander @fhennig
Update docs/modules/getting_started/pages/installation.adoc
877386e 
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@maltesander
Copy link
Member Author

maltesander commented Aug 18, 2022

bors merge
bors bot pushed a commit that referenced this pull request Aug 18, 2022
@maltesander
Getting started guide (#452)
1d99b7e 
# Description fixes #447 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 18, 2022

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Getting started guide [Merged by Bors] - Getting started guide Aug 18, 2022
@bors bors bot closed this Aug 18, 2022
@bors bors bot deleted the getting-started branch August 18, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@maltesander @fhennig