Skip to content

Conversation

@maltesander
Copy link
Member

Description

closes #342

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team March 8, 2022 14:12
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some asciidoc fixes and suggestions.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 14, 2022
## Description closes #342 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Documented service discovery [Merged by Bors] - Documented service discovery Mar 14, 2022
@bors bors bot closed this Mar 14, 2022
@bors bors bot deleted the document_service_discovery branch March 14, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants