Update templated files to rev a89f13e #317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ackabletech/operator-templating repo. Original commit message: Make copying of config-spec conditional (#62) Some operators (looking at you, Regorule) do not have config-spec files, which caused the generate manifest step to fail after PR #61 which changed the syntax for copying these files. This adds a check if any config-spec files are present and skips copying them if not. This requires that operators do not have .dummy files in place, as was the case for regorule (fixed in https://github.com/stackabletech/regorule-operator/pull/195 )
soenkeliebau approved these changes Feb 7, 2022
Member
soenkeliebau left a comment
soenkeliebau left a comment There was a problem hiding this comment.
Installed the Helm chart in a kind cluster, everything looked good to me.
Member
| bors r+ |
bors bot pushed a commit that referenced this pull request Feb 7, 2022
Automatically created PR based on commit a89f13ef75734b1d22f0415c0e1e7b2577d187d7 in stackabletech/operator-templating repo. Original commit message: Make copying of config-spec conditional (#62) Some operators (looking at you, Regorule) do not have config-spec files, which caused the generate manifest step to fail after PR #61 which changed the syntax for copying these files. This adds a check if any config-spec files are present and skips copying them if not. This requires that operators do not have .dummy files in place, as was the case for regorule (fixed in https://github.com/stackabletech/regorule-operator/pull/195 )
Contributor
| Build failed: |
Member
| bors r+ |
bors bot pushed a commit that referenced this pull request Feb 7, 2022
Automatically created PR based on commit a89f13ef75734b1d22f0415c0e1e7b2577d187d7 in stackabletech/operator-templating repo. Original commit message: Make copying of config-spec conditional (#62) Some operators (looking at you, Regorule) do not have config-spec files, which caused the generate manifest step to fail after PR #61 which changed the syntax for copying these files. This adds a check if any config-spec files are present and skips copying them if not. This requires that operators do not have .dummy files in place, as was the case for regorule (fixed in https://github.com/stackabletech/regorule-operator/pull/195 )
Contributor
| Build failed: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Automatically created PR based on commit a89f13ef75734b1d22f0415c0e1e7b2577d187d7 in stackabletech/operator-templating repo.
Original commit message:
Make copying of config-spec conditional (#62)
Some operators (looking at you, Regorule) do not have config-spec files, which caused the generate manifest step to fail after PR #61 which changed the syntax for copying these files.
This adds a check if any config-spec files are present and skips copying them if not. This requires that operators do not have .dummy files in place, as was the case for regorule (fixed in https://github.com/stackabletech/regorule-operator/pull/195 )