Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 7, 2025

Description

In SUP-159 a customer wanted to enable security for the Namenode HTTP API.
This resulted in /dfshealth.html returning a 401 instead of a 200 - thus failing the liveness probe.

This PR allows customers to configOverride security for the HTTP APIs (hopefully until we support them natively)

We intentionally did not write a curl script that checks for 200 or 401 but just went with the TCP port.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Changes are OpenShift compatible - [x] CRD changes approved - [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [x] Helm chart can be installed and deployed operator works - [x] Integration tests passed (for non trivial changes) - [x] Changes need to be "offline" compatible 
# Reviewer - [x] Code contains useful comments - [x] Changelog updated - [x] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added - [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated 
@sbernauer sbernauer changed the title chore: Switch WebUI liveness probe to tcp socket instead of httpGet chore: Switch liveness probe to tcp socket instead of httpGet Jan 7, 2025
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

Thanks for the review!

@sbernauer sbernauer added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit ac6dc70 Jan 8, 2025
17 checks passed
@sbernauer sbernauer deleted the chore/switch-web-ui-probe-to-tcp-port branch January 8, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment