Skip to content

feat: Support configuring JVM arguments #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 29, 2025
Merged

feat: Support configuring JVM arguments #636

merged 14 commits into from
Jan 29, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 27, 2024 •
edited
Loading

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Changes are OpenShift compatible - [x] CRD changes approved - [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [x] Changes need to be "offline" compatible 
# Reviewer - [ ] Code contains useful comments - [ ] Code contains useful logging statements - [ ] (Integration-)Test cases added - [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added - [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated
@sbernauer sbernauer marked this pull request as draft December 27, 2024 10:48
@sbernauer sbernauer mentioned this pull request Dec 27, 2024
Closed
@sbernauer
Copy link
Member Author

Quick smoke test: https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/14/
@sbernauer sbernauer marked this pull request as ready for review January 28, 2025 14:12
maltesander
maltesander requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things, LGTM otherwise.
@sbernauer
Copy link
Member Author

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/20/
sbernauer and others added 3 commits January 28, 2025 16:37
@sbernauer @maltesander
Update CHANGELOG.md
4f420c0 
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer @maltesander
Update rust/operator-binary/src/config/jvm.rs
882fb32 
Co-authored-by: Malte Sander <contact@maltesander.com>
@sbernauer
constants. constants everywhere.
61345c4
@sbernauer sbernauer requested a review from maltesander January 28, 2025 15:55
maltesander
maltesander approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passes!
@sbernauer
Copy link
Member Author

Tests passed 🚀
@sbernauer sbernauer added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 7b9a2a4 Jan 29, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-args branch January 29, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@sbernauer @maltesander