Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Dec 9, 2024

Description

Part of stackabletech/issues#527

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [ ] Changes need to be "offline" compatible 
# Reviewer - [ ] Code contains useful comments - [ ] Code contains useful logging statements - [ ] (Integration-)Test cases added - [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added - [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated 
@razvan
Copy link
Member Author

razvan commented Dec 12, 2024

🟢 CI https://testing.stackable.tech/job/hdfs-operator-it-custom/13/

The failed smoke test was due to case.go:361: failed in step 60-unleash-the-chaosmonkey

nightkr
nightkr previously approved these changes Dec 13, 2024
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the failing test's not good, but smells like preexisting flakiness?

@nightkr nightkr self-requested a review December 13, 2024 11:50
@nightkr nightkr dismissed their stale review December 13, 2024 11:50

missing log dir

nightkr
nightkr previously approved these changes Dec 17, 2024
@razvan razvan enabled auto-merge December 17, 2024 15:31
@razvan razvan added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit a7f2cf5 Dec 17, 2024
17 checks passed
@razvan razvan deleted the feature/containerdebug branch December 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants