Skip to content

feat: Support setting TLS certificate lifetimes #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 4, 2024
Merged

feat: Support setting TLS certificate lifetimes #619

merged 10 commits into from
Dec 4, 2024

Conversation

@razvan
Copy link
Member

@razvan razvan commented Nov 29, 2024 •
edited
Loading

Description

Part of: stackabletech/issues#586

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [ ] Changes need to be "offline" compatible 
# Reviewer - [ ] Code contains useful comments - [ ] Code contains useful logging statements - [ ] (Integration-)Test cases added - [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added - [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated
@razvan razvan requested a review from a team November 29, 2024 11:15
@razvan razvan mentioned this pull request Nov 29, 2024
Closed
@razvan razvan changed the title feat: requestedSecretLifetime role group property added feat: Support setting TLS certificate lifetimes Nov 29, 2024
@sbernauer
Copy link
Member

Just for the record for others: I'd say stackabletech/hbase-operator#598 is the template - which is currently under review. Please place your feedback there
@razvan razvan self-assigned this Dec 3, 2024
sbernauer
sbernauer requested changes Dec 4, 2024
View reviewed changes
razvan and others added 3 commits December 4, 2024 10:03
@razvan @sbernauer
Update CHANGELOG.md
f85f263 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan @sbernauer
Update rust/crd/src/lib.rs
589ccca 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
implement review feedback
9245f3d
sbernauer
sbernauer approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@razvan razvan enabled auto-merge December 4, 2024 09:34
@razvan razvan added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 58eeb42 Dec 4, 2024
17 checks passed
@razvan razvan deleted the feat/issue-586 branch December 4, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.3.0

4 participants

@razvan @sbernauer @lfrancke