-
- Notifications
You must be signed in to change notification settings - Fork 7
docs: rego rule explanation and links #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exceeds what I expected to document, so many thanks :)
I'm not 100% sure if we want to link to the rego rules in hdfs-utils and integration tests. I think it's a bit easier to only have a single source of truth - which needs to be the integration test to align with trino-operator
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Yes, good point. I'd quite like to keep the reference to |
| Ahh I see the point of including the test 👍 Yep, that suggestion sounds good to me 👍 |
Thinking about this, in trino-operator we have the rego rules and the tests. We could copy/paste the approach to hdfs-operator, so that we can link to rego rules and tests with a single link. I can volunteer to copy the setup from trino to hdfs, pls ping me if I should do it in this branch |
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
That would be great @sbernauer : thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can volunteer to copy the setup from trino to hdfs, pls ping me if I should do it in this branch
After spending quite some time on it I think I would drop this. In comparison to trino we need to a.) run jinja template and b.) substitute the namespace when applying.
When doing all of this we loose the benefit of being to opa test it...
So I would say it's totally fine to link to the integration test for the source of truth of rego rules (they are nightly tested) and link to hdfs-utils for the rego rule tests in case someone is interested
Description
fixes #516.
Definition of Done Checklist