Skip to content

Conversation

soenkeliebau
Copy link
Member

@soenkeliebau soenkeliebau commented Nov 22, 2023

Description

fixes #325

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [x] Changes are OpenShift compatible (tested on OKD 4.15) - [x] CRD changes approved - [x] Helm chart can be installed and deployed operator works - [x] Integration tests passed (for non trivial changes) 
# Reviewer - [x] Code contains useful comments - [x] (Integration-)Test cases added - [x] Documentation added or updated - [x] Changelog updated - [x] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 
@fhennig
Copy link
Contributor

fhennig commented Dec 24, 2023

Can you add a new page to the usage guide explaining this feature?

@adwk67 adwk67 requested a review from a team February 29, 2024 08:18
@adwk67
Copy link
Member

adwk67 commented Mar 4, 2024

All tests pass on Openshift. Latest subset run: topology-provider and kerberos (with chaosmonkey) tests:

--- PASS: kuttl (1352.29s) --- PASS: kuttl/harness (0.00s) --- PASS: kuttl/harness/topology-provider_hadoop-latest-3.3.4_zookeeper-latest-3.8.3_kerberos-backend-mit_openshift-true (342.02s) --- PASS: kuttl/harness/kerberos_hadoop-latest-3.3.4_zookeeper-latest-3.8.3_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-true (1343.58s) ... --- PASS: kuttl/harness/orphaned-resources_hadoop-latest-3.3.4_zookeeper-latest-3.8.3 (174.36s) --- PASS: kuttl/harness/logging_hadoop-3.3.6_zookeeper-latest-3.8.3 (296.34s) --- PASS: kuttl/harness/profiling_hadoop-3.3.6_zookeeper-latest-3.8.3_openshift-true (172.60s) --- PASS: kuttl/harness/cluster-operation_hadoop-latest-3.3.4_zookeeper-latest-3.8.3 (297.05s) 

N.B. for OKD 4.14/4.15 tests it may be necessary to run tests with parallel=1 and to restore the resources on the logging test to the defaults.

@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team March 6, 2024 09:17
@adwk67
Copy link
Member

adwk67 commented Mar 6, 2024

Openshift tests (with chaos-monkey) after the merge of PR 491 (noticeably more stable):

--- PASS: kuttl (2257.19s) --- PASS: kuttl/harness (0.00s) --- PASS: kuttl/harness/profiling_hadoop-3.3.6_zookeeper-latest-3.8.3_openshift-true (177.00s) --- PASS: kuttl/harness/cluster-operation_hadoop-latest-3.3.4_zookeeper-latest-3.8.3 (262.05s) --- PASS: kuttl/harness/topology-provider_hadoop-latest-3.3.4_zookeeper-latest-3.8.3_kerberos-backend-mit_openshift-true (331.70s) --- PASS: kuttl/harness/orphaned-resources_hadoop-latest-3.3.4_zookeeper-latest-3.8.3 (163.08s) --- PASS: kuttl/harness/logging_hadoop-3.3.6_zookeeper-latest-3.8.3 (655.99s) --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.8.3_zookeeper-latest-3.8.3_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable (245.62s) --- PASS: kuttl/harness/kerberos_hadoop-latest-3.3.4_zookeeper-latest-3.8.3_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-true (1491.31s) 
@adwk67 adwk67 requested a review from siegfriedweber March 8, 2024 06:50
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 enabled auto-merge March 8, 2024 08:07
@adwk67 adwk67 added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit bc0d9a9 Mar 8, 2024
@adwk67 adwk67 deleted the feat/topology_awareness branch March 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants