fix: Include hdfs principal names in discovery ConfigMap #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fhennig suggested changes Nov 14, 2023
maltesander reviewed Nov 17, 2023
Comment on lines 337 to 338
| hdfs_name: &str, | ||
| hdfs_namespace: &str, |
There was a problem hiding this comment.
Do we really want to add extra parameters for something i can get from the HdfsCluster?
Same for other methods.
Id prefer to just impl this on the cluster object and call it?
There was a problem hiding this comment.
Created #451 based on this review comment, please have a look there
| Superseded by #451 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #419
Fixed while working on stackabletech/hbase-operator#285.
Strangely HBase works without the principals being configured...
Definition of Done Checklist