Skip to content

[Merged by Bors] - docs: reorganized usage guide and 'implementation.adoc' #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - docs: reorganized usage guide and 'implementation.adoc' #302

wants to merge 13 commits into from

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Jan 23, 2023 •
edited
Loading

Description

  • Split up usage into multiple pages
  • deleted implementation.adoc
    • some content was moved to the index.adoc
  • fixed a link that used md syntax
  • removed a nightly reference that was marked with TODO
  • added more cross-links so readers find things easier

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@fhennig fhennig marked this pull request as ready for review January 23, 2023 11:15
@maltesander maltesander self-requested a review January 23, 2023 12:47
maltesander
maltesander requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things..
fhennig and others added 11 commits January 23, 2023 14:49
@fhennig @maltesander
Update docs/modules/ROOT/pages/index.adoc
66b522d 
Co-authored-by: Malte Sander <contact@maltesander.com>
@fhennig @maltesander
Update docs/modules/ROOT/pages/index.adoc
5fa2d78 
Co-authored-by: Malte Sander <contact@maltesander.com>
@fhennig @maltesander
Update docs/modules/ROOT/pages/index.adoc
68ab22f 
Co-authored-by: Malte Sander <contact@maltesander.com>
@fhennig @maltesander
Update docs/modules/ROOT/pages/index.adoc
0c7a5dc 
Co-authored-by: Malte Sander <contact@maltesander.com>
@fhennig @maltesander
Update docs/modules/ROOT/pages/usage-guide/monitoring.adoc
c8b4eea 
Co-authored-by: Malte Sander <contact@maltesander.com>
fix: removed incorrect statement about data nodes
de6a8bd
added log4j.properties
9957d54
Removed incorrect statement about defaults
c2c24bc
Removed more outdated stuff
d7863fa
~
6dacd9b
DataNode instead of data node (and similar for the other node types)
146d33d
maltesander
maltesander approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@fhennig
Copy link
Contributor Author

fhennig commented Jan 24, 2023

bors merge
bors bot pushed a commit that referenced this pull request Jan 24, 2023
@fhennig
docs: reorganized usage guide and 'implementation.adoc' (#302)
2a80908 
# Description - Split up usage into multiple pages - deleted implementation.adoc - some content was moved to the index.adoc - fixed a link that used md syntax - removed a nightly reference that was marked with TODO - added more cross-links so readers find things easier Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title docs: reorganized usage guide and 'implementation.adoc' [Merged by Bors] - docs: reorganized usage guide and 'implementation.adoc' Jan 24, 2023
@bors bors bot closed this Jan 24, 2023
@bors bors bot deleted the docs/minor-restructuring branch January 24, 2023 07:54
fhennig added a commit that referenced this pull request Jan 26, 2023
@fhennig
docs: reorganized usage guide and 'implementation.adoc' (#302)
cc860b3 
- Split up usage into multiple pages - deleted implementation.adoc - some content was moved to the index.adoc - fixed a link that used md syntax - removed a nightly reference that was marked with TODO - added more cross-links so readers find things easier Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
fhennig added a commit that referenced this pull request Jan 26, 2023
@fhennig
docs: reorganized usage guide and 'implementation.adoc' (#302)
cb7b39e 
- Split up usage into multiple pages - deleted implementation.adoc - some content was moved to the index.adoc - fixed a link that used md syntax - removed a nightly reference that was marked with TODO - added more cross-links so readers find things easier Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@fhennig @maltesander