Skip to content

[Merged by Bors] - Fix node selection #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Fix node selection #286

wants to merge 6 commits into from

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 20, 2022 •
edited
Loading

Description

parent ticket: stackabletech/issues#300

This PR:

  • refactors the StatefulSet creation to use the PodBuilder
  • Adds the missing node_selector setting
  • Refactors the replica count extraction from the RoleGroups to avoid some code.

Review Checklist

  • Code contains useful comments
  • CRD change approved (not applicable)
  • (Integration-)Test cases added (not applicable, as decided in the parent ticket)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@fhennig fhennig mentioned this pull request Dec 20, 2022
Closed
4 tasks
@fhennig fhennig marked this pull request as ready for review December 20, 2022 14:19
@fhennig fhennig requested a review from a team December 20, 2022 14:21
sbernauer
sbernauer approved these changes Dec 20, 2022
View reviewed changes
fhennig and others added 2 commits December 21, 2022 08:57
@fhennig @sbernauer
Update rust/operator/src/hdfs_controller.rs
a64fc36 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@fhennig @sbernauer
Update rust/operator/src/hdfs_controller.rs
f6850b1 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@fhennig
Copy link
Contributor Author

fhennig commented Dec 21, 2022

bors merge
bors bot pushed a commit that referenced this pull request Dec 21, 2022
@fhennig
Fix node selection (#286)
8c765c0 
# Description parent ticket: stackabletech/issues#300 This PR: - refactors the StatefulSet creation to use the PodBuilder - Adds the missing node_selector setting - Refactors the replica count extraction from the RoleGroups to avoid some code. Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Fix node selection [Merged by Bors] - Fix node selection Dec 21, 2022
@bors bors bot closed this Dec 21, 2022
@bors bors bot deleted the fix/node-selection branch December 21, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@fhennig @sbernauer