Skip to content

Conversation

maltesander
Copy link
Member

Description

fixes #503

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide). - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [ ] Changes need to be "offline" compatible 
# Reviewer - [ ] Code contains useful comments - [ ] Code contains useful logging statements - [ ] (Integration-)Test cases added - [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide). - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added 
@maltesander maltesander requested a review from a team February 13, 2024 11:41
@maltesander maltesander self-assigned this Feb 13, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit bb97a7b Feb 15, 2024
@maltesander maltesander deleted the support-druid-28.0.1 branch February 15, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants