[Merged by Bors] - Support tls encryption and authentication #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ation # Conflicts: # deploy/crd/druidcluster.crd.yaml # deploy/helm/druid-operator/crds/crds.yaml # deploy/manifests/crds.yaml
…ation # Conflicts: # deploy/crd/druidcluster.crd.yaml # deploy/helm/druid-operator/crds/crds.yaml # deploy/manifests/crds.yaml
…ation # Conflicts: # CHANGELOG.md # rust/crd/src/lib.rs # rust/operator-binary/src/druid_controller.rs
maltesander added release-note 
razvan requested review from razvan and vsupalov and removed request for a team 
razvan reviewed Nov 10, 2022
There was a problem hiding this comment.
There is lot going on in here but it look very good in general
- The new example/tls is missing the Zookeeper resources
- Some additional (unit and integration) tests would help.
- The docs could be more clear what the difference between setting
tlsandauthenticationis.
I haven't run the getting started code.
…on go hand in hand
7 tasks
razvan reviewed Nov 11, 2022
tests/templates/kuttl/tls/01-install-minio-certificates.yaml.j2 Outdated Show resolved Hide resolved
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
| bors merge |
bors bot pushed a commit that referenced this pull request Nov 14, 2022
# Description - Added TLS encryption - Added TLS Authenication Currently CRD looks like: ``` apiVersion: druid.stackable.tech/v1alpha1 kind: DruidCluster metadata: name: derby-druid spec: version: 24.0.0-stackable0.1.0 clusterConfig: authentication: tls: authenticationClass: druid-mtls-authentication-class deepStorage: hdfs: configMapName: druid-hdfs directory: /druid metadataStorageDatabase: dbType: derby connString: jdbc:derby://localhost:1527/var/druid/metadata.db;create=true host: localhost port: 1527 tls: secretClass: tls zookeeperConfigMapName: druid-znode ``` Not quite happy for the authentication part, basically the same information is repeated in the referenced AuthenticationClass. Still mergeable for now, we need to come up with a better way first. Test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/37/ fixes #6 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
| Pull request successfully merged into main. Build succeeded: |
bors bot changed the title bors bot pushed a commit that referenced this pull request Nov 14, 2022
# Description This doesn't add or change any functionality. Fixes #335 Required for #306 This is based on #333 and has to be merged after that. :green_circle: CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/39/ ## Review Checklist - [x] Code contains useful comments - [x] CRD change approved (or not applicable) - [x] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Currently CRD looks like:
Not quite happy for the authentication part, basically the same information is repeated in the referenced AuthenticationClass.
Still mergeable for now, we need to come up with a better way first.
Test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/37/
fixes #6
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information