Skip to content

Add Stacklet docs page #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jun 24, 2024
Merged

Add Stacklet docs page #613

merged 47 commits into from
Jun 24, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented May 27, 2024 •
edited
Loading

also replaces the roles and role groups page - it was the first page I wrote and very wordy, and it fits nicely into the Stacklet page, as a Stacklet is mostly made up of roles.

I then went into all the concept pages and adjusted some text to mention the Stacklet in more places, as well as adjusting formatting to our style guide.

closes #541. The new page mentions that naming conflicts can occur.
@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 51ba5a7
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/6672d0af73fd3c00088cce5e
😎 Deploy Preview https://deploy-preview-613--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
@fhennig fhennig marked this pull request as ready for review May 28, 2024 08:36
@fhennig fhennig self-assigned this May 28, 2024
@fhennig fhennig requested a review from razvan May 28, 2024 08:36
NickLarsenNZ
NickLarsenNZ previously approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit-picky, so approving and leaving it up to you whether you accept some of the suggestions.

Some stuff I commented on was just reformatted from what was already there, so not necessary to change in this PR.
@fhennig @NickLarsenNZ
Update modules/concepts/pages/index.adoc
6078b43 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
fhennig and others added 14 commits May 29, 2024 14:51
@fhennig @NickLarsenNZ
Update modules/concepts/pages/labels.adoc
50b0c9f 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/labels.adoc
f55d8c9 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/labels.adoc
e4ca51a 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/logging.adoc
58080e6 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/opa.adoc
4477a22 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overrides.adoc
4408f9b 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overrides.adoc
e4d93a7 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/service-exposition.adoc
e3887fd 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/service-exposition.adoc
c9e38a0 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/resources.adoc
82773ce 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/resources.adoc
9b8feb8 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overrides.adoc
816cc04 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overrides.adoc
8da0870 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overrides.adoc
b3b4c60 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
fhennig and others added 19 commits May 29, 2024 15:04
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overview.adoc
a1faa3f 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/overview.adoc
4f219af 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stacklet.adoc
91d785b 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stacklet.adoc
53bbbc0 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stacklet.adoc
288c9be 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stacklet.adoc
23efc01 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stackable_resource_requests.adoc
3554689 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stackable_resource_requests.adoc
b0c2ce8 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/service-exposition.adoc
4a95cac 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/service-exposition.adoc
21b8fc9 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/service-exposition.adoc
341d220 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig
clarify role text
7638f1c
@fhennig
change stacklet text
40d2b4e
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stacklet.adoc
af3caf4 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig @NickLarsenNZ
Update modules/concepts/pages/stackable_resource_requests.adoc
5c238a6 
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@fhennig
change CPU resource text
b363e60
@fhennig
change process to component
0e7f8d4
@fhennig
remove confusing sentence
3d04e18
@fhennig
add suggestion
ef3bc24
NickLarsenNZ
NickLarsenNZ reviewed Jun 11, 2024
View reviewed changes
fhennig and others added 2 commits June 12, 2024 12:25
@fhennig fhennig requested a review from NickLarsenNZ June 12, 2024 10:25
@fhennig fhennig enabled auto-merge June 19, 2024 12:36
NickLarsenNZ
NickLarsenNZ approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@fhennig fhennig added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 61aea6c Jun 24, 2024
@fhennig fhennig deleted the add-stacklet-concepts-page branch June 24, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@fhennig @razvan @NickLarsenNZ