Skip to content

Conversation

Techassi
Copy link
Member

Follow-up of #561

@Techassi Techassi requested a review from fhennig March 12, 2024 09:04
@Techassi Techassi self-assigned this Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit dd72b1d
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/65f01ab6cfa687000841224b
😎 Deploy Preview https://deploy-preview-562--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Techassi
Copy link
Member Author

Okay, I just tested the changes and they don't seem to work. The page https://deploy-preview-562--stackable-docs.netlify.app/home/nightly/contributor/logging does not redirect to https://deploy-preview-562--stackable-docs.netlify.app/home/nightly/contributor/guidelines/logging

Is there anything I need to add in addition to the page aliases?

@fhennig
Copy link
Contributor

fhennig commented Mar 12, 2024

it works if you add .html

thanks for adding them!

@Techassi
Copy link
Member Author

Ohhh, okay :)

@Techassi Techassi added this pull request to the merge queue Mar 12, 2024
@fhennig
Copy link
Contributor

fhennig commented Mar 12, 2024

but yeah it's weird that the .html isn't there by default, so maybe it's all pointless 😅

Merged via the queue into main with commit fdb134a Mar 12, 2024
@Techassi Techassi deleted the chore/add-page-aliases branch March 12, 2024 09:18
@Techassi
Copy link
Member Author

Yeah... It feels a little pointless. To work like we expected, it would need an index.html file in the logging folder which then redirects to guidelines/logging (which again is an index.html file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants