Skip to content

Documentation about setup in in air-gapped environment #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 23, 2024
Merged

Documentation about setup in in air-gapped environment #530

merged 6 commits into from
Jan 23, 2024

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented Jan 18, 2024 •
edited
Loading

Fixes #270
@netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 4f2251f
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/65afe1d348f4ee0008542d78
😎 Deploy Preview https://deploy-preview-530--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
lfrancke
lfrancke previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!
@fhennig do you also want to take another look?
@fhennig
Copy link
Contributor

fhennig commented Jan 23, 2024

Thanks! I like it too, I think we can merge it as is.

I have an optional suggestion: Add a "Further reading" or "Read more" bit, where you link to offline image veriifcation. I think someone that reads this tutorial would be interested in that topic too, it helps with discoverability in the docs.

but LGTM!!
@dervoeti
Copy link
Member Author

It was already there, but a bit hidden at the end. It's still at the end, but I made it more prominent.
@dervoeti dervoeti added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 42d89e8 Jan 23, 2024
@dervoeti dervoeti deleted the feat/add-airgap-setup-documentation branch January 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dervoeti @fhennig @lfrancke