added a note on PVC usage #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nightkr reviewed Jun 30, 2022
fhennig reviewed Jun 30, 2022
fhennig suggested changes Jun 30, 2022
| Sorry for not submitting all this feedback at once! |
| waiting for @fhennig to get back |
fhennig suggested changes Jul 25, 2022
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For some clusters (IONOS, Azure, AWS) PVC-usage for tests requires explicit node selection, whereas for others (K3S, KinD) this is taken into account. This note provides a short explanation.