Skip to content

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Jun 1, 2022

closes #183

This PR adds a page to the contributors guide about documentation style. It is brief, linking to the k8s and google docs, with some specific aspects mentioned explicitly.

The document is also linked in the menu and in the step-by-step guide in the section on contributing documentation.

razvan
razvan previously approved these changes Jun 1, 2022
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general idea and will have to read the articles linked.

nightkr
nightkr previously approved these changes Jun 1, 2022
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@fhennig fhennig dismissed stale reviews from nightkr and razvan via dd160b5 June 1, 2022 12:33
fhennig and others added 6 commits June 1, 2022 14:34
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@fhennig fhennig requested review from nightkr and razvan June 1, 2022 12:40
@fhennig fhennig merged commit f68a020 into main Jun 1, 2022
@fhennig fhennig deleted the style-guide branch June 1, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants