Skip to content

Service discovery #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2022
Merged

Service discovery #166

merged 3 commits into from
Mar 28, 2022

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Mar 18, 2022 •
edited
Loading

  • added contributors guide to service discovery

closes #142
@maltesander maltesander requested a review from a team March 18, 2022 14:07
@maltesander maltesander self-assigned this Mar 18, 2022
@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team March 28, 2022 11:19
siegfriedweber
siegfriedweber requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks good in general. My two points of criticism are:

  • The "source code" of the image is missing.
  • The implementation details should not be added.
siegfriedweber
siegfriedweber approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@maltesander maltesander merged commit 773c55d into main Mar 28, 2022
@maltesander maltesander deleted the service_discovery branch March 28, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@maltesander @siegfriedweber