Skip to content

Add secret-operator #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2022
Merged

Add secret-operator #155

merged 3 commits into from
Mar 9, 2022

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Feb 25, 2022

@nightkr nightkr requested a review from a team March 8, 2022 13:45
@nightkr
Copy link
Contributor Author

nightkr commented Mar 8, 2022

R4R now that stackabletech/secret-operator#64 is merged.
maltesander
maltesander approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@nightkr
Copy link
Contributor Author

nightkr commented Mar 8, 2022

bors r+
@bors
Copy link

bors bot commented Mar 8, 2022

Configuration problem:
bors.toml: not found
@lfrancke
Copy link
Member

lfrancke commented Mar 8, 2022

This will also require adding it to the menu, right? I believe it's not there at the moment.
@nightkr
Copy link
Contributor Author

nightkr commented Mar 8, 2022

That's correct, since the menu is controlled by the UI bundle… :/
@lfrancke lfrancke merged commit 8f31036 into main Mar 9, 2022
@lfrancke lfrancke deleted the chore/secrets branch March 9, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@nightkr @lfrancke @maltesander