Skip to content

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Nov 8, 2023

Description

Add hbase-operator-tools to the HBase image

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible - [x] All added packages (via microdnf or otherwise) have a comment on why they are added - [x] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there - [x] All packages should have (if available) signatures/hashes verified - [ ] Does your change affect an SBOM? Make sure to update all SBOMs 
@siegfriedweber siegfriedweber requested review from a team and lfrancke November 8, 2023 10:44
@siegfriedweber siegfriedweber self-assigned this Nov 8, 2023
@lfrancke
Copy link
Member

lfrancke commented Nov 8, 2023

I'm building it now, it looks good in principle but has one problem that will be hard to overcome: HBase Operator Tools builds against Hadoop 2 I believe but to fix that would be rather annoying.

If it works (did you test that @siegfriedweber?) I'm fine with it for now as we'll get a fix for this automatically when we upgrade to HBase 2.5++

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Nov 8, 2023

I tested HBCK2 with scheduleRecoveries and recoverUnknown:

version=1.2.0 # Schedule ServerCrashProcedure (SCP) for the given RegionServers /stackable/hbase/bin/hbase hbck \ -j /stackable/hbase-operator-tools/hbase-hbck2/hbase-hbck2-$version.jar \ scheduleRecoveries $regionservers # Schedule ServerCrashProcedure (SCP) for RegionServers that are reported as unknown /stackable/hbase/bin/hbase hbck \ -j /stackable/hbase-operator-tools/hbase-hbck2/hbase-hbck2-$version.jar \ recoverUnknown
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three things:

  • One change request: Add the license to hbase/licenses/
  • A suggestion but I'm fine merging it without: Add a shell script wrapper hbck2 that does the necessary call to hbase with all the stuff wired up and put that shell in the PATH
  • A suggestion: Should we add a note in the docs about this tool being included?
@siegfriedweber
Copy link
Member Author

  • One change request: Add the license to hbase/licenses/

added in 15de8ea

  • A suggestion but I'm fine merging it without: Add a shell script wrapper hbck2 that does the necessary call to hbase with all the stuff wired up and put that shell in the PATH

added in 012da89

  • A suggestion: Should we add a note in the docs about this tool being included?

added in stackabletech/hbase-operator#416

Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, otherwise looks good. I built and tested it, thank you!

@siegfriedweber siegfriedweber added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit f8dbf8d Nov 8, 2023
@siegfriedweber siegfriedweber deleted the feature/add-hbase-operator-tools branch November 8, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment