Skip to content

fix: Fixed various issues in the CRD structure #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2023
Merged

fix: Fixed various issues in the CRD structure #353

merged 3 commits into from
Dec 5, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 5, 2023 •
edited
Loading

Description

Part of stackabletech/issues#469

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author - [ ] Changes are OpenShift compatible - [ ] CRD changes approved - [ ] Helm chart can be installed and deployed operator works - [ ] Integration tests passed (for non trivial changes) - [ ] Changes need to be "offline" compatible 
# Reviewer - [ ] Code contains useful comments - [ ] (Integration-)Test cases added - [ ] Documentation added or updated - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) 
# Acceptance - [ ] Feature Tracker has been updated - [ ] Proper release label has been added
@sbernauer sbernauer self-assigned this Dec 5, 2023
@sbernauer sbernauer mentioned this pull request Dec 5, 2023
Open
fhennig
fhennig previously approved these changes Dec 5, 2023
View reviewed changes
@sbernauer sbernauer enabled auto-merge December 5, 2023 08:29
maltesander
maltesander approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@sbernauer sbernauer added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit d14a62d Dec 5, 2023
@sbernauer sbernauer deleted the fix-crd branch December 5, 2023 14:43
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. type/bug

4 participants

@sbernauer @fhennig @maltesander @lfrancke