Skip to content

[Merged by Bors] - Remove orphaned resources #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Remove orphaned resources #174

wants to merge 2 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Oct 4, 2022 •
edited by fhennig
Loading

Description

Implement removal of orphaned resources. Closes #72.
Jenkins: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/44/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@adwk67 adwk67 marked this pull request as ready for review October 5, 2022 05:14
@adwk67 adwk67 requested a review from a team October 5, 2022 05:15
@fhennig fhennig self-assigned this Oct 5, 2022
fhennig
fhennig suggested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading through, I just foud one thing
@fhennig
Copy link
Contributor

fhennig commented Oct 5, 2022

Okay, I'm fine with making the docs about this some other time, I've added a comment to this ticket stackabletech/documentation#282
@adwk67
Copy link
Member Author

adwk67 commented Oct 5, 2022

bors merge
bors bot pushed a commit that referenced this pull request Oct 5, 2022
@adwk67
Remove orphaned resources (#174)
6c051eb 
# Description Implement removal of orphaned resources. Closes #72. Jenkins: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/44/
@bors
Copy link

bors bot commented Oct 5, 2022

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Remove orphaned resources [Merged by Bors] - Remove orphaned resources Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
@bors bors bot deleted the handle_stale_resources branch October 5, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@adwk67 @fhennig