Skip to content

Conversation

@TomasVotruba
Copy link
Contributor

No description provided.

@staabm
Copy link
Owner

staabm commented Feb 16, 2023

in case you don't want to fiddle with the php-cs-fixer, I would be fine changing to ECS in case its easier for you

@TomasVotruba
Copy link
Contributor Author

I would be fine changing to ECS in case its easier for you

Me too :) but first things first. The composer command handles it well 👍

@TomasVotruba
Copy link
Contributor Author

Not sure why locally the coding style passed and remotely not. Any ideas?

@TomasVotruba
Copy link
Contributor Author

Good, I re-run with different PHP version :) 👍

@TomasVotruba
Copy link
Contributor Author

I need help with the SQL fail, as I have no idea where that does come from.

@staabm
Copy link
Owner

staabm commented Feb 16, 2023

I will push it over the finish line, thank you.

seems some kind of whitespace difference in error messages

@TomasVotruba
Copy link
Contributor Author

Thanks a lot 💯

You're probably right. I assume the SQL is longer in doctrine/dbal 2.13

Query error: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "freigabe1u1"
LINE 1: SELECT email adaid WHERE gesperrt freigabe1u1 FROM ada LIMIT...
^ (42601).
TEXT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 👍

I wonder if these would be better in txt files, as the spacing is crappy here and in PHP 7.3+ herenowdoc change can backfire again :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its easier to maintain in a single file instead of distributing it all over. its good enough for now :)

@staabm staabm merged commit 0b6d95e into staabm:main Feb 16, 2023
@staabm
Copy link
Owner

staabm commented Feb 16, 2023

thanks you!

@staabm
Copy link
Owner

staabm commented Feb 16, 2023

@williamdes
Copy link

awesome, thank you!

@TomasVotruba TomasVotruba deleted the tv-php-72 branch February 16, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants