Review Changes to support NTLM and Kerberos proxy authentication in websocket-sharp #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Updated handling of TCPClient connect async, to have a timeout of 3 seconds. |
| +1 for this. It is a must have on important Windows infrastructures. Any chance for a review @sta? |
| +1 Any update on this? |
| +1 also from my side. It would be really appreciated! |
| +1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I am working on a project that requires websocket proxy support for ntlm and kerberos authentication. websocket-sharp currently only supports Basic and Digest. I searched for alternative webscoket libaries to support ntlm and kerberos with no luck.
I finally came upon a solution without the need to completely implement proxy ntlm and kerberos authentication from scratch.
I used the articlebelow as the basis for solution.
http://www.replicator.org/journal/201011170043-net-connecting-a-tcpclient-through-an-http-proxy-with-authentication
The solution is based off leveraging the Proxy Authentication handling that is already build into the HttpWebRequest in .NET. A HTTP connect made to the proxy, Authentication is handled internally, then later we reusing the socket to connect to the remote end point.
This solution is already being used by xscokets client when user sets their Proxy.
https://github.com/XSockets/XSockets.Clients/blob/master/src/XSockets.Clients/XSockets.Client35/XSocketClient.cs
Proposal is to have this available websocket-sharp in an official release