Skip to content

Fix documentation example. #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2019
Merged

Fix documentation example. #970

merged 2 commits into from
Oct 14, 2019

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Oct 10, 2019 •
edited
Loading

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I updated go-mysql-server using make upgrade command if applicable.
  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.
@ajnavarro ajnavarro requested a review from a team October 10, 2019 10:43
@ajnavarro
Fix documentation example.
9ae39a4 
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the fix-documentation-example branch from 24095b4 to 9ae39a4 Compare October 10, 2019 10:44
agarciamontoro
agarciamontoro approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to automatically run these examples as part of our CI.
@ajnavarro ajnavarro merged commit 514115e into src-d:master Oct 14, 2019
@ajnavarro ajnavarro deleted the fix-documentation-example branch October 14, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@ajnavarro @juanjux @erizocosmico @carlosms @agarciamontoro