Fix php 8.1 error for trim() function #3676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a quick fix, but I don't know if it's normal that some $this->files array keys are 'null'
Contributor
| @Kleinast Could you please elaborate how you got this error ? If PHPCS is used as intended, that error shouldn't be possible... |
Contributor
| Hang on - just now seeing issue #3677. Will continue there. |
4 tasks
Contributor
| This has now been fixed via PHPCSStandards/PHP_CodeSniffer#1150 and the fix will be included in the 3.13.3 release. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a quick fix, but I don't know if it's normal that some $this->files array keys are 'null'