Skip to content

Conversation

kukulich
Copy link
Contributor

No description provided.

@kukulich kukulich mentioned this pull request Nov 20, 2021
8 tasks
@kukulich kukulich force-pushed the php81-readonly branch 3 times, most recently from 1753d8e to 2bd65e9 Compare November 20, 2021 10:58
@kukulich kukulich marked this pull request as draft November 20, 2021 10:59
@kukulich kukulich force-pushed the php81-readonly branch 9 times, most recently from a8ec2c9 to 5398ede Compare November 20, 2021 11:51
@kukulich kukulich marked this pull request as ready for review November 20, 2021 11:54
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @kukulich ! I've left some notes and suggestions in-line.

@kukulich kukulich marked this pull request as draft November 20, 2021 15:03
@kukulich kukulich force-pushed the php81-readonly branch 2 times, most recently from 99f72fa to 857d0b5 Compare November 20, 2021 16:26
@kukulich kukulich marked this pull request as ready for review November 20, 2021 16:30
@kukulich kukulich force-pushed the php81-readonly branch 2 times, most recently from 0401f9d to 197cfa4 Compare November 20, 2021 18:41
@gsherwood gsherwood added this to the 3.7.0 milestone Nov 21, 2021
@gsherwood gsherwood merged commit 21bd369 into squizlabs:master Dec 17, 2021
@gsherwood
Copy link
Member

Thanks a lot for this contribution.

I made a couple of little changes, including adding support for readonly const. While it is a syntax error in 8.1, it still tokenizes as T_READONLY...

@kukulich kukulich deleted the php81-readonly branch December 17, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants