Tokenizer arrow functions backfill tests: fix it ;-) #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Follow up on 2860. This fixes the tests. #### Test case file: * Adds tests with mixed case `fn` keyword. * Removes a few redundant tests (weren't testing anything which wasn't covered already). #### Test file: * Adds a couple of tests which were missing from the data provider. * Updates the test itself to use a `$testContent` parameter to allow for the `fn` in the tests being non-lowercase.
jrfnl force-pushed the feature/2860-tokenizer-arrow-function-backfill-fix-tests branch from 78c5000 to 2adcb64 Compare 
| Rebased, added mixed case tests and updated the PR description above. Should be good to go. |
| Related to #2523 |
gsherwood added a commit that referenced this pull request Feb 9, 2020
jrfnl deleted the feature/2860-tokenizer-arrow-function-backfill-fix-tests branch 
| Thanks a lot |
| @gsherwood You're welcome. |
gsherwood pushed a commit that referenced this pull request Feb 9, 2020
This commit implements the proposal as outlined in 2859#issuecomment-583695917. The `fn` keyword will now only be tokenized as `T_FN` if it really is an arrow function, in which case it will also have the additional indexes set in the token array. In all other cases - including when the keyword is used in a function declaration for a named function or method -, it will be tokenized as `T_STRING`. Includes numerous additional unit tests. Includes removing the changes made to the `File::getDeclarationName()` function and the `AbstractPatternSniff` in commit 37dda44 as those are no longer necessary. Fixes #2859 Fixed tests for #2860 Tokenizer arrow functions backfill tests: fix it ;-) Follow up on 2860. This fixes the tests. * Adds tests with mixed case `fn` keyword. * Removes a few redundant tests (weren't testing anything which wasn't covered already). * Adds a couple of tests which were missing from the data provider. * Updates the test itself to use a `$testContent` parameter to allow for the `fn` in the tests being non-lowercase. Added a few more tests for the T_FN backfill (ref #2863, #2860, #2859)
tobias-trozowski pushed a commit to tobias-trozowski/PHP_CodeSniffer that referenced this pull request Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow up on #2860. This fixes the tests.
Test case file:
fnkeyword.Test file:
$testContentparameter to allow for thefnin the tests being non-lowercase.