Skip to content

JS Tokenizer generates errors when processing some decimals #915

@photodude

Description

@photodude

In trying to figure out why testing with my custom standard is failing to complete, I ran a quick test against the Pear standard in PHPCS just to make sure things are running right. I ended up getting the following errors at about 74%

PHP Notice: Undefined index: bracket_closer in /CodeSniffer/Tokenizers/JS.php on line 1062 PHP Stack trace: PHP 1. {main}() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:0 PHP 2. PHP_CodeSniffer_CLI->runphpcs() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:25 PHP 3. PHP_CodeSniffer_CLI->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:104 PHP 4. PHP_CodeSniffer->processFiles() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:886 PHP 5. PHP_CodeSniffer->processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:619 PHP 6. PHP_CodeSniffer->_processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1714 PHP 7. PHP_CodeSniffer_File->start() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1836 PHP 8. PHP_CodeSniffer_File->_parse() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:471 PHP 9. PHP_CodeSniffer_File::tokenizeString() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:689 PHP 10. PHP_CodeSniffer_Tokenizers_JS->processAdditional() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:1447 

This error

PHP Notice: Undefined index: content in /CodeSniffer/Fixer.php on line 139 PHP Stack trace: PHP 1. {main}() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:0 PHP 2. PHP_CodeSniffer_CLI->runphpcs() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:25 PHP 3. PHP_CodeSniffer_CLI->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:104 PHP 4. PHP_CodeSniffer->processFiles() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:886 PHP 5. PHP_CodeSniffer->processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:619 PHP 6. PHP_CodeSniffer->_processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1714 PHP 7. PHP_CodeSniffer_File->start() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1836 PHP 8. PHP_CodeSniffer_Fixer->startFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:472 

This error

PHP Notice: Undefined index: bracket_closer in CodeSniffer/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 951 PHP Stack trace: PHP 1. {main}() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:0 PHP 2. PHP_CodeSniffer_CLI->runphpcs() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:25 PHP 3. PHP_CodeSniffer_CLI->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:104 PHP 4. PHP_CodeSniffer->processFiles() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:886 PHP 5. PHP_CodeSniffer->processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:619 PHP 6. PHP_CodeSniffer->_processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1714 PHP 7. PHP_CodeSniffer_File->start() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1836 PHP 8. Generic_Sniffs_WhiteSpace_ScopeIndentSniff->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:567 

this error

PHP Notice: Undefined index: line in CodeSniffer/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 952 PHP Stack trace: PHP 1. {main}() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:0 PHP 2. PHP_CodeSniffer_CLI->runphpcs() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:25 PHP 3. PHP_CodeSniffer_CLI->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:104 PHP 4. PHP_CodeSniffer->processFiles() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:886 PHP 5. PHP_CodeSniffer->processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:619 PHP 6. PHP_CodeSniffer->_processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1714 PHP 7. PHP_CodeSniffer_File->start() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1836 PHP 8. Generic_Sniffs_WhiteSpace_ScopeIndentSniff->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:567 

this error

PHP Notice: Undefined offset: 2845 in CodeSniffer/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 217 PHP Stack trace: PHP 1. {main}() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:0 PHP 2. PHP_CodeSniffer_CLI->runphpcs() /home/travis/.phpenv/versions/5.6.5/bin/phpcs:25 PHP 3. PHP_CodeSniffer_CLI->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:104 PHP 4. PHP_CodeSniffer->processFiles() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/CLI.php:886 PHP 5. PHP_CodeSniffer->processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:619 PHP 6. PHP_CodeSniffer->_processFile() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1714 PHP 7. PHP_CodeSniffer_File->start() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer.php:1836 PHP 8. Generic_Sniffs_WhiteSpace_ScopeIndentSniff->process() /home/travis/.phpenv/versions/5.6.5/pear/PHP/CodeSniffer/File.php:567 

and lots more errors
see Travis-ci RAW log for details and all the errors
Also Failing with similar errors using the PSR2 standard
And with the PSR1 standard
And with the PHPCS standard

  • a file that you analyze: Testing against this Repo on Travis-CI
  • standard definition you're using: PEAR (for this test only)
  • used PHP_CodeSniffer version: Current stable 2.5.1
  • used PHP version: 5.6.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions