- Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
Description
We got some "Named colours are forbidden" (Squiz.CSS.NamedColours.Forbidden) errors from using named colours such as "white" in CSS class names. Turn out this is due to double dashes, which are recognized as T_DEC. Hence the "previous token was hash or string concat" check fails.
Should be easy to fix. :-)
Example:
.something--white { border: 0; }
[CSS => 18 tokens in 4 lines]... *** START TOKEN PROCESSING *** Process token 0: T_OPEN_TAG => Processing Generic_Sniffs_Files_LineEndingsSniff... DONE in 0 seconds Processing Squiz_Sniffs_WhiteSpace_SuperfluousWhitespaceSniff... DONE in 0 seconds Processing Generic_Sniffs_WhiteSpace_DisallowTabIndentSniff... DONE in 0 seconds Processing Squiz_Sniffs_CSS_IndentationSniff... DONE in 0 seconds Processing Squiz_Sniffs_CSS_DuplicateClassDefinitionSniff... DONE in 0.0001 seconds Process token 1: T_STRING_CONCAT => . Process token 2: T_STRING => something Processing Squiz_Sniffs_CSS_NamedColoursSniff... DONE in 0 seconds Process token 3: T_DEC => -- Process token 4: T_STRING => white Processing Squiz_Sniffs_CSS_NamedColoursSniff... DONE in 0 seconds Process token 5: T_WHITESPACE => · Processing Squiz_Sniffs_WhiteSpace_SuperfluousWhitespaceSniff... DONE in 0 seconds
FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 1 | ERROR | Named colours are forbidden; use hex, rgb, or rgba values instead (Squiz.CSS.NamedColours.Forbidden)