URLencode custom SVGs #8087
Merged
URLencode custom SVGs #8087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When using custom SVGs that contained characters breaking a URL, like a hash # sign that is consiered a URL fragment, the rendering broke. This adds a jinja urlencode filter to the output. Fixes squidfunk#8086
| So, this is confirmed fixing the bug at hand,  …however the styling is unfortunate, all grey, as also already pointed out by @mocdaniel in #8082 (reply in thread) |
| Thanks for the PR. LGTM. |
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using custom SVGs that contained
characters breaking a URL, like a hash #
sign that is consiered a URL fragment,
the rendering broke. This adds a jinja
urlencode filter to the output.
Fixes #8086